aselimov/pubs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #124 from pubs/fix/link_customization

Browse Source 
Removes link and DOI customization. Fixes #119.
This commit is contained in:
Olivier Mangin 2018-03-05 11:16:03 -05:00 committed by GitHub
commit 4ceeccddad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pubs/endecoder.py
View File

@ -50,9 +50,7 @@ def customizations(record):
record = bp.customization.editor(record) record = bp.customization.editor(record)
record = bp.customization.journal(record) record = bp.customization.journal(record)
record = bp.customization.keyword(record) record = bp.customization.keyword(record)
record = bp.customization.link(record)
record = bp.customization.page_double_hyphen(record) record = bp.customization.page_double_hyphen(record)
record = bp.customization.doi(record)
record = sanitize_citekey(record) record = sanitize_citekey(record)
@ -95,8 +93,6 @@ class EnDecoder(object):
entry[BP_ENTRYTYPE_KEY] = entry.pop(TYPE_KEY) entry[BP_ENTRYTYPE_KEY] = entry.pop(TYPE_KEY)
for f in ignore_fields: for f in ignore_fields:
entry.pop(f, None) entry.pop(f, None)
if 'link' in entry:
entry['link'] = ', '.join(link['url'] for link in entry['link'])
if 'author' in entry: if 'author' in entry:
entry['author'] = ' and '.join( entry['author'] = ' and '.join(
author for author in entry['author']) author for author in entry['author'])

12
tests/test_endecoder.py
View File

@ -121,6 +121,18 @@ class TestEnDecode(unittest.TestCase):
self.assertEqual(lines[9].split('=')[0].strip(), u'note') self.assertEqual(lines[9].split('=')[0].strip(), u'note')
self.assertEqual(lines[10].split('=')[0].strip(), u'abstract') self.assertEqual(lines[10].split('=')[0].strip(), u'abstract')
def test_endecode_link_as_url(self):
decoder = endecoder.EnDecoder()
if 'url = ' not in bibtex_raw0:
raise NotImplementedError(
'The fixture bibraw0 has been changed; test needs an update.')
raw_with_link = bibtex_raw0.replace('url = ', 'link = ')
entry = decoder.decode_bibdata(raw_with_link)
lines = decoder.encode_bibdata(entry).splitlines()
self.assertEqual(lines[8].split('=')[0].strip(), u'url')
self.assertEqual(lines[8].split('=')[1].strip(),
u'{http://ilpubs.stanford.edu:8090/422/},')
def test_endecode_bibtex_ignores_fields(self): def test_endecode_bibtex_ignores_fields(self):
decoder = endecoder.EnDecoder() decoder = endecoder.EnDecoder()
entry = decoder.decode_bibdata(bibtex_raw0) entry = decoder.decode_bibdata(bibtex_raw0)