From 93c7fb2f27e5c9e2966255927a4e12c8804559c5 Mon Sep 17 00:00:00 2001
From: Olivier Mangin <olivier.mangin@inria.fr>
Date: Tue, 15 Apr 2014 19:34:03 +0200
Subject: [PATCH] Moves TestFakeFs helper to fake_env module.

---
 tests/fake_env.py        | 20 +++++++++++---------
 tests/test_databroker.py |  9 ---------
 tests/test_filebroker.py | 13 ++-----------
 3 files changed, 13 insertions(+), 29 deletions(-)

diff --git a/tests/fake_env.py b/tests/fake_env.py
index 3f69ffc..6a6bfe9 100644
--- a/tests/fake_env.py
+++ b/tests/fake_env.py
@@ -3,16 +3,14 @@ import os
 import shutil
 import glob
 import unittest
-import pkgutil
-import re
 
 import dotdot
 import fake_filesystem
 import fake_filesystem_shutil
 import fake_filesystem_glob
 
-from pubs import color
 from pubs.p3 import io, input
+from pubs import content, filebroker
 
     # code for fake fs
 
@@ -48,12 +46,7 @@ def create_fake_fs(module_list):
 
     fake_fs.CreateDirectory(fake_os.path.expanduser('~'))
 
-    try:
-        __builtins__.open = fake_open
-        __builtins__.file = fake_open
-    except AttributeError:
-        __builtins__['open'] = fake_open
-        __builtins__['file'] = fake_open
+    __builtins__.update({'open': fake_open, 'file': fake_open})
 
     sys.modules['os']     = fake_os
     sys.modules['shutil'] = fake_shutil
@@ -160,3 +153,12 @@ class FakeInput():
         self._cursor += 1
         return inp
 
+
+class TestFakeFs(unittest.TestCase):
+    """Abstract TestCase intializing the fake filesystem."""
+
+    def setUp(self):
+        self.fs = create_fake_fs([content, filebroker])
+
+    def tearDown(self):
+        unset_fake_fs([content, filebroker])
diff --git a/tests/test_databroker.py b/tests/test_databroker.py
index 22c30cc..d79c24a 100644
--- a/tests/test_databroker.py
+++ b/tests/test_databroker.py
@@ -10,15 +10,6 @@ from pubs import content, filebroker, databroker, datacache
 import str_fixtures
 from pubs import endecoder
 
-class TestFakeFs(unittest.TestCase):
-    """Abstract TestCase intializing the fake filesystem."""
-
-    def setUp(self):
-        self.fs = fake_env.create_fake_fs([content, filebroker])
-
-    def tearDown(self):
-        fake_env.unset_fake_fs([content, filebroker])
-
 
 class TestDataBroker(unittest.TestCase):
 
diff --git a/tests/test_filebroker.py b/tests/test_filebroker.py
index 8d8d2cb..67c8b20 100644
--- a/tests/test_filebroker.py
+++ b/tests/test_filebroker.py
@@ -7,17 +7,8 @@ import fake_env
 
 from pubs import content, filebroker
 
-class TestFakeFs(unittest.TestCase):
-    """Abstract TestCase intializing the fake filesystem."""
 
-    def setUp(self):
-        self.fs = fake_env.create_fake_fs([content, filebroker])
-
-    def tearDown(self):
-        fake_env.unset_fake_fs([content, filebroker])
-
-
-class TestFileBroker(TestFakeFs):
+class TestFileBroker(fake_env.TestFakeFs):
 
     def test_pushpull1(self):
 
@@ -89,7 +80,7 @@ class TestFileBroker(TestFakeFs):
         self.assertFalse(fb.exists('citekey1'))
 
 
-class TestDocBroker(TestFakeFs):
+class TestDocBroker(fake_env.TestFakeFs):
 
     def test_doccopy(self):