From a14d6441a4fe17afc01b9f6e1d6e759b8a5dda60 Mon Sep 17 00:00:00 2001 From: Mitsuhiro Nakamura Date: Sat, 11 Dec 2021 12:49:41 +0900 Subject: [PATCH] refactor: rename variables --- pubs/commands/import_cmd.py | 6 +++--- pubs/utils.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pubs/commands/import_cmd.py b/pubs/commands/import_cmd.py index 918709d..a33e467 100644 --- a/pubs/commands/import_cmd.py +++ b/pubs/commands/import_cmd.py @@ -41,7 +41,7 @@ def parser(subparsers, conf): return parser -def many_from_path(ui, bibpath, excluded_bibtex_fields=[], ignore=False): +def many_from_path(ui, bibpath, bibtex_field_excludes=[], ignore=False): """Extract list of papers found in bibliographic files in path. The behavior is to: @@ -65,7 +65,7 @@ def many_from_path(ui, bibpath, excluded_bibtex_fields=[], ignore=False): try: bibentry = coder.decode_bibdata(read_text_file(filepath)) # exclude bibtex fields if specified - remove_bibtex_fields(bibentry, excluded_bibtex_fields) + remove_bibtex_fields(bibentry, bibtex_field_excludes) biblist.append(bibentry) except coder.BibDecodingError: error = "Could not parse bibtex at {}.".format(filepath) @@ -105,7 +105,7 @@ def command(conf, args): rp = repo.Repository(conf) # Extract papers from bib papers = many_from_path(ui, bibpath, - excluded_bibtex_fields=conf['main']['bibtex_field_excludes'], + bibtex_field_excludes=conf['main']['bibtex_field_excludes'], ignore=args.ignore_malformed) keys = args.keys or papers.keys() for k in keys: diff --git a/pubs/utils.py b/pubs/utils.py index 8c3ebbf..a49894a 100644 --- a/pubs/utils.py +++ b/pubs/utils.py @@ -88,8 +88,8 @@ def standardize_doi(doi): return new_doi -def remove_bibtex_fields(bibentry, excluded_bibtex_fields=[]): +def remove_bibtex_fields(bibentry, fields): for item in bibentry.values(): - for field in excluded_bibtex_fields: + for field in fields: if field in item: del item[field]