cleanup PR

pubs/bibstruct.py

@@ -51,11 +51,9 @@ def author_last(author_str):
     return author_str.split(',')[0]
 
 
-def generate_citekey(bibdata, generate=True):
+def generate_citekey(bibdata):
     """ Generate a citekey from bib_data.
 
-        :param generate:  if False, return the citekey defined in the file,
-                          does not generate a new one.
         :raise ValueError:  if no author nor editor is defined.
     """
     citekey, entry = get_entry(bibdata)

pubs/repo.py

@@ -200,6 +200,7 @@ class Repository(object):
         """
         # can't have `/` in citekeys
         # FIXME: a bit crude, but efficient for now (and allows unicode citekeys)
+        # TODO:  check that the generated citekey does not have a slash too.
         if '/' in base_key:
             base_key = bibstruct.generate_citekey(bibentry)
         for n in itertools.count():