aselimov/pubs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor refactoring of string comparison in query filters.

Browse Source
This commit is contained in:
Olivier Mangin 2018-01-30 17:42:56 -05:00
parent c87b89bf10
commit cff028d345
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pubs/query.py
View File

@ -29,6 +29,9 @@ class QueryFilter(object):
def __call__(self, paper): def __call__(self, paper):
raise NotImplementedError raise NotImplementedError
def _is_query_in(self, field_value):
return self.query in self._lower(field_value)
def _lower(self, s): def _lower(self, s):
return s if self.case else s.lower() return s if self.case else s.lower()
@ -42,7 +45,7 @@ class FieldFilter(QueryFilter):
def __call__(self, paper): def __call__(self, paper):
return (self.field in paper.bibdata and return (self.field in paper.bibdata and
self.query in self._lower(paper.bibdata[self.field])) self._is_query_in(paper.bibdata[self.field]))
class AuthorFilter(QueryFilter): class AuthorFilter(QueryFilter):
@ -52,14 +55,14 @@ class AuthorFilter(QueryFilter):
if 'author' not in paper.bibdata: if 'author' not in paper.bibdata:
return False return False
else: else:
return any([self.query in self._lower(bibstruct.author_last(author)) return any([self._is_query_in(bibstruct.author_last(author))
for author in paper.bibdata['author']]) for author in paper.bibdata['author']])
class TagFilter(QueryFilter): class TagFilter(QueryFilter):
def __call__(self, paper): def __call__(self, paper):
return any([self.query in self._lower(t) for t in paper.tags]) return any([self._is_query_in(t) for t in paper.tags])
class YearFilter(QueryFilter): class YearFilter(QueryFilter):