fixed bug in datacache + added corresponding tests

papers/datacache.py

@@ -47,7 +47,7 @@ class DataCache(object):
         self.databroker.remove(citekey)
 
     def exists(self, citekey, both=True):
-        self.databroker.exists(citekey, both=both)
+        return self.databroker.exists(citekey, both=both)
 
     def citekeys(self):
         listings = self.listing(filestats=False)

tests/test_databroker.py

@@ -28,12 +28,17 @@ class TestDataBroker(TestFakeFs):
         page99_metadata = ende.decode_metadata(str_fixtures.metadata_raw0)
         page99_bibdata  = ende.decode_bibdata(str_fixtures.bibyaml_raw0)
 
-        dtb = databroker.DataBroker('tmp', create=True)
-        dtc = datacache.DataCache('tmp')
+        for db_class in [databroker.DataBroker, datacache.DataCache]:
+            self.fs = fake_env.create_fake_fs([content, filebroker])
+            
+            db = db_class('tmp', create=True)
 
-        for db in [dtb, dtc]:
             db.push_metadata('citekey1', page99_metadata)
+            self.assertTrue(db.exists('citekey1', both=False))
+            self.assertFalse(db.exists('citekey1', both=True))
+
             db.push_bibdata('citekey1', page99_bibdata)
+            self.assertTrue(db.exists('citekey1', both=True))
 
             self.assertEqual(db.pull_metadata('citekey1'), page99_metadata)
             self.assertEqual(db.pull_bibdata('citekey1'), page99_bibdata)