691 Commits

Author SHA1 Message Date
Olivier Mangin
42d75d1230
Merge branch 'master' into fix/doc_add 2018-08-20 13:25:40 +02:00
Olivier Mangin
c2e52ec4c4
Makes 'copy' the default for the add_doc configuration option. 2018-08-20 12:18:23 +02:00
Olivier Mangin
668d30ffbf
Allows move for import on explicit option.
- uses `copy` as a default (hence no need for the option),
- does not use `doc_add` config for import.
2018-08-20 12:14:25 +02:00
Olivier Mangin
81aa1cddf4
Merge pull request #155 from pubs/jma/arxiv
Handle arXiv errors and other improvements.

- handles old/new style arxiv references
- normalize arXiv citekeys
- improves error handling of doi/isbn (raise Exception if an HTTP status is detected).
- fix the isbn parse test that was incorrectly using doi2bibtex.
- add feedparser to the requirements.txt file.
- allows to run the tests using pytest.
2018-08-20 11:44:53 +02:00
Olivier Mangin
c4bf5eef87
Merge branch 'master' into jma/arxiv 2018-08-14 13:23:44 +02:00
Olivier Mangin
de7644f90a
Merge pull request #160 from pubs/feat/stats
Adds the statistics command. (Fixes #8)
2018-08-14 13:20:36 +02:00
Fabien C. Y. Benureau
51aa9795fd
add 3.7 tests 2018-08-14 17:41:58 +09:00
Fabien C. Y. Benureau
8e30ac7400
refix test + switch apis to https 2018-08-14 17:35:59 +09:00
Fabien C. Y. Benureau
0eb069c86a
fix test + sorted json 2018-08-14 17:20:23 +09:00
Fabien C. Y. Benureau
30a7094eaf
add arXiv tests 2018-08-14 17:05:11 +09:00
Olivier Mangin
7dae35e722
Adds the statistics command. (Fixes #8) 2018-08-09 23:48:29 +02:00
Olivier Mangin
7d1c678d3d
Adds changelog entry 2018-08-09 19:22:54 +02:00
Olivier Mangin
8eef7bd77b
Remove code duplication for command arguments. 2018-08-09 19:19:29 +02:00
Olivier Mangin
a8de97c327
Fixes #144: behavior of add_copy mode during add.
- correctly handles add_copy mode and configuration,
- add option top force 'copy' mode (since the default had been changed
in between from 'copy' to 'move' this is now needed),
- fixes assumption in one test that the default is 'copy' (in other
words the test was broken and ensuring that the functionality was broken
too.),
- do not try to delete the source when it is an URL.
2018-08-09 19:00:01 +02:00
Fabien C. Y. Benureau
c62d1c3c50
move test data from pickle to json 2018-08-09 19:51:40 +09:00
Fabien C. Y. Benureau
fdb6e5541d
Add explanation for how mock work. Fix pickle protocol error for Python 2.7. 2018-08-07 11:48:28 +09:00
Fabien C. Y. Benureau
bf1b4cd9d7
mock mode for test_apis
The mock system relies on the PUBS_TESTS_MODE environmental variable.
See the `tests/mock_requests.py` code for details.
By defaults, fast mock tests are used with data pre-fetched from real
calls.
2018-08-07 11:30:13 +09:00
Fabien C. Y. Benureau
be80e75cbb
better error message when parsing of bibtex fails
Plus, slight refactoring: remove `databroker.verify()` method
2018-08-06 17:45:30 +09:00
Fabien C. Y. Benureau
69f760cac6
dev_requirements.txt + explanation 2018-08-06 11:28:14 +09:00
Fabien C. Y. Benureau
938a53b8f5
python setup.py test + no connection case
- Make `python setup.py test work`. remove test/requirements.txt.
  fix #154
- Detect if no connection is present, and skip tests if not.
  stop-gap measure for issue #147
2018-08-06 11:20:50 +09:00
Fabien C. Y. Benureau
814ce1bde2
remove timespec argument from isoformat (introduced in 3.6) 2018-08-05 22:19:56 +09:00
Fabien C. Y. Benureau
647fea8ddb
update doi fail test, fix isbn test 2018-08-05 22:16:01 +09:00
Fabien C. Y. Benureau
be253f9084
handling of arxiv errors 2018-08-05 22:08:00 +09:00
Fabien C. Y. Benureau
bf46702374
pytest fixes
pytest will automatically run/collect anything that begins with "test".
Renamed a few thing to avoid false positive.
2018-08-05 22:07:23 +09:00
Fabien C. Y. Benureau
20c5ed7446
Merge pull request #146 from joe-antognini/jma/arxiv
Arxiv support for pubs add.
2018-08-05 21:48:57 +09:00
J. Antognini
d6ab091e5c Only allow one of doi, arxiv, or isbn to pubs_add
Also includes some minor refactoring.
2018-08-05 00:00:20 -07:00
Olivier Mangin
6e72b0e2f7
Merge branch 'master' into jma/arxiv 2018-08-02 12:01:10 +02:00
Olivier Mangin
c6edacf3ec
Merge pull request #149 from pubs/fix87
Fix #87 (more robust error handling and list command)
2018-08-01 15:38:02 +02:00
Olivier Mangin
03900c324a
Adds changelog entry. 2018-08-01 15:12:48 +02:00
Olivier Mangin
ea2bc7f732
Merge branch 'master' into fix87 2018-08-01 15:02:01 +02:00
Olivier Mangin
fe2e31e2d0
Merge pull request #151 from pubs/fix/pyfakefs37
Fix compatibility with latest Pyfakefs.
2018-08-01 15:01:39 +02:00
Olivier Mangin
13f21a3d28
Minor grammar in warning. 2018-08-01 14:43:32 +02:00
Olivier Mangin
9093cbfbed
Add changelog entry for #151. 2018-08-01 14:42:15 +02:00
Olivier Mangin
3d76501a5c
Merge branch 'master' into fix/pyfakefs37 2018-08-01 14:36:24 +02:00
Fabien C. Y. Benureau
cf97f681ef
cleanup commented code, better reset_fs() 2018-08-01 14:37:23 +09:00
Fabien C. Y. Benureau
c76c7607f9
Upgrade pyfakefs to current version
Fix #148. Also did some cleanup on the tests.
2018-08-01 14:22:18 +09:00
Olivier Mangin
95d314a2aa
Merge pull request #150 from pubs/changelog
[Fix #85] Adds changelog file.
2018-07-31 11:09:50 +02:00
Olivier Mangin
bc239aba69
Removes italic on one contributor. 2018-07-31 11:08:05 +02:00
Olivier Mangin
5a47150aad
Adds option to ignore malformed bibtex files or entry during import. 2018-07-30 18:24:56 +02:00
Olivier Mangin
60650b874a
Addresses minor comments (error message and better test). 2018-07-30 17:46:04 +02:00
Olivier Mangin
754e926893
Adds authors of PRs to changelog and missing ksunden to readme. 2018-07-30 17:27:12 +02:00
J. Antognini
ccdbe72eb7 Address omangin's code review.
* This fixes the logic in the `pubs add` command so that an arxiv ID doesn't
  overwrite a DOI.  This also changes the logic so that if an invalid DOI, ISBN,
  or arXiv ID is provided the program will raise an error.

* The code now uses the bibtexparser package to generate the bibtex file for
  arxiv papers.

* A dedicated exception is added for references that can't be found.
2018-07-28 22:37:14 -07:00
Olivier Mangin
7518dfd56a
[Fix #85] Adds changelog file. 2018-07-26 16:34:02 +02:00
Olivier Mangin
ea711b6b42
[Fix #87] Include citekey in message on bibtex decoding error from repository.
Catches decoding error at databroker level to include citekey in message.
Could be improved by a better exception class for BibDecodingError.
2018-07-25 22:52:27 +02:00
Olivier Mangin
8a7d143261
Improves behaviors related to bibtex decoding error.
- from editor input in add and edit commands,
- from files in import command.
2018-07-25 22:20:14 +02:00
Olivier Mangin
d8dc386a18
Fix fake input behavior in tests on unexpected input.
Because of the mechanism for catching exceptions in pubs, the
UnexpectedInput exception raised by FakeInput never reached the catch
statement in the CommandTestCase and raised a FakeSystemExit instead.

This commit monkey-patches the exception handler in the ui at the same
time as the patching of the input functions to ignore UnexptectedInput
at the ui level.
2018-07-25 19:59:23 +02:00
Olivier Mangin
2f48f37199
Fixes duplicated test names in same TestCase (1st was not run). 2018-07-25 18:30:26 +02:00
Olivier Mangin
99dfcd1691
Merge pull request #142 from pubs/feat/dialogedit
Dialog after editing paper
2018-07-25 17:36:28 +02:00
Olivier Mangin
6957ae3cbb
Merge branch 'master' into feat/dialogedit 2018-07-25 17:24:06 +02:00
Olivier Mangin
fbd29d27a4
Merge pull request #141 from pubs/feat/editor_missing
error message when editor is missing
2018-07-25 17:23:06 +02:00