Replace deprecated pipes with shlex

.github/workflows/tests.yaml

@@ -3,23 +3,27 @@ name: Pubs tests
 on:
   push:
   pull_request:
+  workflow_dispatch:
   schedule:
-    - cron: '0 8 * * *'
+    - cron: '0 8 * * MON'
 
 
 jobs:
   unit-test:
-    name: Run unit tests
+    name: Run unit tests with mock requests
     strategy:
       matrix:
-        os: [macos-latest, ubuntu-latest]
+        os: [ubuntu-latest, macos-latest]
-        python-version: [3.6, 3.7, 3.8, 3.9]
+        python-version: ['3.10']
+        include:
+          - os: ubuntu-20.04
+            python-version: '3.6'
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install dependencies
@@ -37,6 +41,33 @@ jobs:
         env:
           PUBS_TESTS_MODE: MOCK
         run: pytest
+
+
+  unit-test-online:
+    name: Run unit tests online
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        python-version: ['3.10']
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v3
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r dev_requirements.txt
+      - name: Configure git author (fix issue with environment variable)
+        run: |
+          # Manually sets some git user and email to avoid failure of the test
+          # (For some reason the environment variables set in the test are not
+          # taken into account by git on the runner.)
+          git config --global user.name "Pubs test"
+          git config --global user.email "unittest@pubs.org"
       - name: Test with pytest (online API mode)
         env:
           PUBS_TESTS_MODE: COLLECT
@@ -51,7 +82,7 @@ jobs:
     if: github.event_name == 'schedule'
 
     steps:
-      - uses: actions/setup-python@v2
+      - uses: actions/setup-python@v3
       - name: install test
         run: |
           pip install -U pip

.gitignore

@@ -2,7 +2,8 @@
 *~
 .DS_Store
 .eggs
-
+env.sh
+.venvs
 
 *.py[cod]
 

pubs/plugs/alias/alias.py

@@ -1,7 +1,7 @@
 import shlex
 import subprocess
 import argparse
-from pipes import quote as shell_quote
+from shlex import quote as shell_quote
 
 from ...plugins import PapersPlugin
 from ...pubs_cmd import execute

pubs/plugs/git/git.py

@@ -2,7 +2,7 @@ import os
 import sys
 import argparse
 from subprocess import Popen, PIPE, STDOUT
-from pipes import quote as shell_quote
+from shlex import quote as shell_quote
 
 from ... import uis
 from ...plugins import PapersPlugin

readme.md

@@ -1,3 +1,4 @@
+**Note this is my fork of the pubs code originally written by benureau (https://github.com/pubs/pubs)**
 # Pubs
 
 Pubs brings your bibliography to the command line.

tests/test_doi.py

@@ -20,7 +20,7 @@ class TestDOIStandardization(unittest.TestCase):
         self.hard_dois = (
             '10.1175/1520-0485(2002)032<0870:CT>2.0.CO;2',
             '10.1002/(SICI)1522-2594(199911)42:5<952::AID-MRM16>3.0.CO;2-S',
-            '10.1579/0044-7447(2006)35\[89:RDUICP\]2.0.CO;2',
+            '10.1579/0044-7447(2006)35[89:RDUICP]2.0.CO;2',
         )
 
         self.currently_not_supported = (
@@ -78,3 +78,7 @@ class TestDOIStandardization(unittest.TestCase):
         for doi in self.currently_not_supported:
             with self.assertRaises(ValueError):
                 standardize_doi(doi)
+
+
+if __name__ == '__main__':
+    unittest.main()