542 Commits

Author SHA1 Message Date
Bill Flynn
66c90c5d43 Added unittest to cover new behavior pubs
Unittest just checks that both `pubs` and `pubs --help` raise a
`SystemExit` exception with error code 0.  Due to how argparse
handles the `--help` keyword, this is the best way I could think to
provide test coverage without heavily modifying the parser structure
or the unittest infrastructure.

To ensure the `pubs` matches the behavior of `pubs --help`, it now
raises the same `SystemExit(0)` exception via `sys.exit(0)`.  And
in order to catch it in the unittest, I had to modify the
`FakeSystemExit` behavior slightly.
2017-11-30 14:48:50 -05:00
Bill Flynn
ac3a8d8bf2 Print help menu when no subcommands applied
Made subparsers not required in the main parser, but if no commands are parsed,
then the parser prints its help.  When a command is present, the normal
functionality preserved.

Removed the single unittest that checks for this exact behavior.
2017-11-28 17:32:13 -05:00
Olivier Mangin
5676cb49a9
Merge pull request #96 from pubs/fix/content
Fixes content not read from urls because of call to `os.abspath`
2017-11-02 13:45:23 -04:00
Olivier Mangin
4ea9f2101d
Merge pull request #97 from pubs/fix/config
Fix defaults not used in config.
2017-11-02 13:44:41 -04:00
Olivier Mangin
66b51997ea Fix defaults not used in config.
Basically the validation takes care of setting results that
post-processing was relying on. Hence the validation should occur before
the postprocessing. It actually makes more sense to validate within
post-process.
2017-10-19 16:40:45 -04:00
Olivier Mangin
6a26216c3e COSMIT 2017-10-19 15:46:42 -04:00
Olivier Mangin
a65873a7e0 Fixes abspath called on urls preventing to get content from url.
Fix #7
2017-10-19 15:40:58 -04:00
Olivier Mangin
f6035cac80 Merge pull request #94 from pubs/fix/93
Fix #93: actually save the modifications on `edit -m`.
2017-10-18 10:58:17 -04:00
Olivier Mangin
47f5c918ea Fix #93: saves the modifications on edit -m. 2017-10-17 16:50:23 -04:00
Olivier Mangin
2cab1666e8 Merge pull request #91 from pubs/fix/88
[Fix #88] Adds proper escaping for arguments in alias plugin.
2017-10-03 23:04:30 -04:00
Olivier Mangin
922781a89a Moves shell_quote import out of p3.py 2017-10-03 22:53:08 -04:00
Olivier Mangin
5c74f942c4 [Fix #88] Adds proper escaping for arguments in alias plugin. 2017-09-28 17:34:32 -04:00
Olivier Mangin
be3c124079 Fix update code. 2017-08-06 18:58:45 -04:00
Olivier Mangin
d40b86a9cf Updates version everywhere. 2017-08-06 18:58:45 -04:00
Olivier Mangin
3e05ad6d19 Releases 0.7.0 2017-08-06 18:07:18 -04:00
Olivier Mangin
b63a132ac4 Version update. 2017-08-06 18:02:24 -04:00
Fabien C. Y. Benureau
6cccc021f8 Minor fix for isbn2index docstring 2017-08-06 18:02:24 -04:00
Olivier Mangin
a286b118f4 Improves instructions in README. 2017-08-06 17:49:32 -04:00
Olivier Mangin
bd872e807d Lowercase license file. 2017-08-02 20:33:54 -04:00
Olivier Mangin
4f638ba9b6 Merge pull request #82 from pubs/bug/conf_cmd
Fixes bug in conf command and adds unittest
2017-08-01 23:49:08 -04:00
Olivier Mangin
69d7587108 Adds test for configuration file content in usecase. 2017-08-01 23:43:06 -04:00
Fabien C. Y. Benureau
366575763c Remove duplicate test 2017-08-01 23:43:06 -04:00
Fabien C. Y. Benureau
0942df3b50 Fix pubs conf command 2017-08-01 23:43:06 -04:00
Olivier Mangin
fd084bb827 Merge branch 'fix/76' 2017-07-22 15:45:52 -04:00
Olivier Mangin
da6f07c6c9 Adds basic API test for DOI and ISBN. 2017-07-22 15:42:12 -04:00
Olivier Mangin
38fc68adbc Refactors filebroker to remove file duplication. 2017-07-22 13:35:13 -04:00
Olivier Mangin
983d1892e0 Removes unused imports. 2017-07-22 13:35:13 -04:00
Olivier Mangin
7b19a9dcdd Forces utf8 when no encoding in header for DOI request.
The default behavior from the requests library is to use the guess from
chardet which is not always reliable while doi.org seems to always
return utf8 encoded data. It's unlikely that this changes without also
updating the header.
2017-07-22 13:35:13 -04:00
Olivier Mangin
cf596206b0 FIX: Encode unicode before writing to file in python2.
This is necessary because _open returns a file descriptor in binary mode
for python2.
2017-07-22 13:35:13 -04:00
Olivier Mangin
81f2661593 Cosmit 2017-07-22 13:35:13 -04:00
Fabien Benureau
0dd51aff58 Merge pull request #79 from pubs/bug/websearch_fix
Fixes websearch in Python 3 (fix #69)
2017-07-17 19:05:58 +02:00
Fabien C. Y. Benureau
1f224a90c7 Fixes websearch in Python 3 (fix #69) 2017-07-17 15:42:06 +02:00
Olivier Mangin
d281a82025 Merge pull request #71 from pubs/feat/note_extension
[notes] Allow different file extension for note file (closes #70).
2017-07-12 12:22:09 -04:00
Olivier Mangin
4ffd62fe9f [notes] Allow different file extension for note file (see #70). 2017-07-12 10:41:51 -04:00
Olivier Mangin
cd63575034 Merge pull request #74 from pubs/feat/require_argcomplete
Adds argcomplete as an optional requirement.
2017-07-12 10:36:57 -04:00
Olivier Mangin
af503fd0eb Argcomplete as an optional requirement. 2017-07-12 10:26:05 -04:00
Fabien C. Y. Benureau
bc71557461 Add argcomplete to required package (easier installation) 2017-07-12 10:26:05 -04:00
Fabien Benureau
7e3cd61628 Merge pull request #73 from pubs/bug/unittests
Bug/unittests
2017-07-12 10:16:09 +02:00
Olivier Mangin
9b6496d740 Removed commented code with old imports. 2017-07-11 17:26:08 -04:00
Olivier Mangin
323fb8b674 Fixes indent and removes unused io import. 2017-07-11 17:13:39 -04:00
Fabien C. Y. Benureau
3b4cfe635d Fix tests for Python 2
Also, some cleanup in fake_env.py
2017-07-11 17:08:53 -04:00
Fabien C. Y. Benureau
66a91b3c0c Fix content._open for Python 2 2017-07-11 17:08:53 -04:00
Fabien C. Y. Benureau
ce4b66e9b4 Fix unittests for Python 3 2017-07-11 17:08:52 -04:00
Fabien Benureau
2465f821ba Merge pull request #61 from pubs/feat/autocomplete
Feat/autocomplete
2017-07-09 23:38:07 +02:00
Fabien C. Y. Benureau
a99e97c716 Streamline autocompletion explanations in readme
Important details about Bash were not mentioned in our explanation. Furthermore,
these instructions may get obsolete at any moment. Better to delegate to the
argcomplete project.
2017-07-09 21:09:19 +02:00
Fabien C. Y. Benureau
4ac5889123 Update installation section in readme 2017-07-09 20:58:56 +02:00
Olivier Mangin
e129398311 Pass the config to plugins on parser modification to allow completion. 2017-07-08 00:10:15 -04:00
Olivier Mangin
576d907a78 Adds instructions for zsh completion. 2017-07-08 00:10:15 -04:00
Olivier Mangin
92fb403871 Fix function in FakeModule. 2017-07-08 00:10:15 -04:00
Olivier Mangin
ce3ed1e52f Use ImportError for older python versions. 2017-07-08 00:10:15 -04:00